Skip to content

Update spark, ldk, and cdk#56

Merged
benthecarman merged 9 commits into
masterfrom
update-deps
May 8, 2026
Merged

Update spark, ldk, and cdk#56
benthecarman merged 9 commits into
masterfrom
update-deps

Conversation

@benthecarman
Copy link
Copy Markdown
Collaborator

@benthecarman benthecarman commented May 6, 2026

No description provided.

@benthecarman benthecarman force-pushed the update-deps branch 2 times, most recently from 10b9140 to 18b2112 Compare May 6, 2026 21:29
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
benthecarman and others added 7 commits May 7, 2026 14:04
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace deprecated actions-rs/toolchain@v1 with dtolnay/rust-toolchain@stable
and the manual actions/cache@v3 setup with Swatinem/rust-cache@v2. The
purpose-built Rust cache action keys correctly on Cargo.lock + rustc version
(the old key only hashed Cargo.toml so cargo update wouldn't bust it), prunes
the parts of target/ that don't help on restore, and keeps build-script
outputs so the bitcoind/electrs binaries downloaded by corepc-node and
electrsd remain cached.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
build_test_nodes was funding the LSP, mining 6 blocks, then funding the
third-party node and mining another 6. The two fundings are independent —
broadcast both txs first and confirm with one batch of 6 blocks. Drops one
6-block confirmation wait (~10s on this machine) per integration test.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The split into 50+51 batches dates to a regtest setup pre-modern bitcoind
where 101 blocks could time out the default RPC. With current bitcoind 29.0
this fits comfortably in one call.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The 1-second invoice has already expired by the time we need it expired;
sleeping 5x as long doesn't add safety, just CI time.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
create_lsp and create_third_party each called set_listening_addresses with
the same address twice. The second call replaces the first, so the second
call alone is equivalent.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@benthecarman benthecarman merged commit 4d0293a into master May 8, 2026
1 of 3 checks passed
@benthecarman benthecarman deleted the update-deps branch May 8, 2026 00:08
@benthecarman benthecarman self-assigned this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant